HappenLee commented on code in PR #64413:
URL: https://github.com/apache/doris/pull/64413#discussion_r3426616377
##########
be/src/storage/segment/segment_iterator.cpp:
##########
@@ -2203,31 +2072,50 @@ bool
SegmentIterator::_can_evaluated_by_vectorized(std::shared_ptr<ColumnPredica
}
}
-bool SegmentIterator::_prune_column(ColumnId cid, MutableColumnPtr& column,
bool fill_defaults,
- size_t num_of_defaults) {
- if (_need_read_data(cid)) {
- return false;
- }
- if (!fill_defaults) {
- return true;
- }
- if (is_column_nullable(*column)) {
+void SegmentIterator::_fill_default_column(MutableColumnPtr& column, size_t
num_of_defaults) {
+ if (column->is_nullable()) {
auto nullable_col_ptr =
reinterpret_cast<ColumnNullable*>(column.get());
Review Comment:
这里为什么不能直接用那个columnNullable的 insert_many_defaults，反正都是填充不用的数据，为什么不直接填充null呢
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
