HappenLee commented on code in PR #64413:
URL: https://github.com/apache/doris/pull/64413#discussion_r3426574539
##########
be/src/storage/rowset/beta_rowset_reader.cpp:
##########
@@ -101,14 +101,13 @@ Status
BetaRowsetReader::get_segment_iterators(RowsetReaderContext* read_context
_read_options.stats = _stats;
_read_options.push_down_agg_type_opt =
_read_context->push_down_agg_type_opt;
_read_options.common_expr_ctxs_push_down =
_read_context->common_expr_ctxs_push_down;
+ DORIS_CHECK(_read_context->return_columns != nullptr);
Review Comment:
这行在这里很突兀啊,你要么就移到这个97行这里,要么就移到这个全部等于完之后。这也没有个上下文,我感觉不应该在这里check啊
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]