starocean999 commented on code in PR #64026:
URL: https://github.com/apache/doris/pull/64026#discussion_r3418689932
##########
fe/fe-core/src/main/java/org/apache/doris/analysis/PartitionValue.java:
##########
@@ -76,13 +74,15 @@ public boolean equals(Object o) {
return false;
}
PartitionValue that = (PartitionValue) o;
- return isNullPartition == that.isNullPartition
- && Objects.equal(value, that.value);
+ boolean result = isNullPartition == that.isNullPartition
+ && Objects.equal(value, that.value)
Review Comment:
原来代码是直接比较string value。目前已保证新增的常量比较时，类型一定是一致的。结合这两点，行为和之前没有差异
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
