starocean999 commented on code in PR #64026:
URL: https://github.com/apache/doris/pull/64026#discussion_r3418651687
##########
fe/fe-core/src/main/java/org/apache/doris/catalog/PartitionKey.java:
##########
@@ -118,15 +109,7 @@ public static PartitionKey
createPartitionKey(List<PartitionValue> keys, List<Co
Preconditions.checkArgument(keys.size() <= columns.size());
int i;
for (i = 0; i < keys.size(); ++i) {
- Type keyType = columns.get(i).getType();
- // If column type is datatime and key type is date, we should
convert date to datetime.
- // if it's max value, no need to parse.
- if (!keys.get(i).isMax() && (keyType.isDatetime() ||
keyType.isDatetimeV2() || keyType.isTimeStampTz())) {
- Literal dateTimeLiteral =
getDateTimeLiteral(keys.get(i).getStringValue(), keyType);
- partitionKey.keys.add(dateTimeLiteral.toLegacyLiteral());
- } else {
- partitionKey.keys.add(keys.get(i).getValue(keyType));
- }
+ partitionKey.keys.add(keys.get(i).getValue());
partitionKey.types.add(columns.get(i).getDataType());
Review Comment:
常量比较时，类型已保持一致
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
