xiaokang commented on code in PR #15437: URL: https://github.com/apache/doris/pull/15437#discussion_r1058702422
########## fe/fe-core/src/main/java/org/apache/doris/rewrite/ExtractCommonFactorsRule.java: ########## @@ -462,6 +464,13 @@ private Expr rewriteOrToIn(List<Expr> exprs) { boolean isOrToInAllowed = true; Set<String> slotSet = new LinkedHashSet<>(); + int rewriteThreshold; + if (ConnectContext.get() == null) { + rewriteThreshold = 2; Review Comment: is default value 2 too small? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org