Henry2SS commented on code in PR #15437:
URL: https://github.com/apache/doris/pull/15437#discussion_r1058126654
##########
fe/fe-core/src/test/java/org/apache/doris/planner/QueryPlanTest.java:
##########
@@ -2238,5 +2238,14 @@ public void testRewriteOrToIn() throws Exception {
sql = "SELECT * from test1 where (query_time = 1 or query_time = 2)
and (scan_bytes = 2 or scan_bytes = 3)";
explainString = UtFrameUtils.getSQLPlanOrErrorMsg(connectContext,
"EXPLAIN " + sql);
Assert.assertTrue(explainString.contains("PREDICATES: `query_time` IN
(1, 2), `scan_bytes` IN (2, 3)"));
+
+
connectContext.getSessionVariable().setRewriteOrToInPredicateThreshold(100);
+ sql = "SELECT * from test1 where query_time = 1 or query_time = 2 or
query_time in (3, 4)";
Review Comment:
> REWRITE_OR_TO_IN_PREDICATE_THRESHOLD 包含 in的数量吗？
包含的。只要是 compound predicate 且 是OR连接的，都是包括了的，都算在exprs里面。
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
