github-actions[bot] commented on code in PR #15398: URL: https://github.com/apache/doris/pull/15398#discussion_r1057520295
########## be/src/io/cache/cache_path_policy.h: ########## @@ -0,0 +1,69 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE file +// distributed with this work for additional information +// regarding copyright ownership. The ASF licenses this file +// to you under the Apache License, Version 2.0 (the +// "License"); you may not use this file except in compliance +// with the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, +// software distributed under the License is distributed on an +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +// KIND, either express or implied. See the License for the +// specific language governing permissions and limitations +// under the License. + +#pragma once + +#include <string> + +#include "common/status.h" + +namespace doris { +namespace io { + +enum class FileCacheType : uint8_t { + NO_CACHE, + SUB_FILE_CACHE, + WHOLE_FILE_CACHE, + FILE_BLOCK_CACHE, +}; + +FileCacheType cache_type_from_string(const std::string& type); + +// CachePathPolicy it to define which cache path should be used +// for the local cache of the given file(path). +// The dervied class should implement get_cache_path() method +class CachePathPolicy { +public: + // path: the path of file which will be cached + // return value: the cache path of the given file. + virtual std::string get_cache_path(const std::string& path) const { return ""; } +}; + +class NoCachePathPolicy : public CachePathPolicy { +public: + NoCachePathPolicy() {} + std::string get_cache_path(const std::string& path) const override { return path; } +}; + +class SegmentCachePathPolicy : public CachePathPolicy { +public: + SegmentCachePathPolicy() {} + std::string get_cache_path(const std::string& path) const override { return path + "/"; } +}; + +class CacheOptions { +public: + CacheOptions(FileCacheType cache_type_, const CachePathPolicy& path_policy_) + : cache_type(cache_type_), path_policy(path_policy_) {} + +public: Review Comment: warning: redundant access specifier has the same accessibility as the previous access specifier [readability-redundant-access-specifiers] ```suggestion ``` **be/src/io/cache/cache_path_policy.h:58:** previously declared here ```cpp public: ^ ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
