pengxiangyu commented on code in PR #15398:
URL: https://github.com/apache/doris/pull/15398#discussion_r1058132159
##########
be/src/io/fs/file_system.h:
##########
@@ -52,6 +53,9 @@ class FileSystem {
virtual Status create_file(const Path& path, FileWriterPtr* writer) = 0;
+ virtual Status open_file(const Path& path, const CacheOptions&
cache_options,
Review Comment:
ReaderOption is better, open_file will create a FileReader，CacheOptions is
not suitable. You can make CacheOptions as an element of ReaderOption.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
