github-actions[bot] commented on code in PR #13035:
URL: https://github.com/apache/doris/pull/13035#discussion_r1057475814
##########
be/src/olap/rowset/segment_v2/segment_iterator.h:
##########
@@ -166,6 +183,18 @@ class SegmentIterator : public RowwiseIterator {
void _update_max_row(const vectorized::Block* block);
+ bool _check_apply_by_bitmap_index(ColumnPredicate* pred);
+
+ std::string _gen_predicate_sign(ColumnPredicate* predicate);
+ std::string _gen_predicate_sign(ColumnPredicateInfo* predicate_info);
+
+ void _build_index_result_column(uint16_t* sel_rowid_idx, uint16_t
select_size,
+ vectorized::Block* block, const
std::string& pred_result_sign,
+ const roaring::Roaring& index_result);
+ void _output_index_result_column(uint16_t* sel_rowid_idx, uint16_t
select_size,
+ vectorized::Block* block);
+
+private:
Review Comment:
warning: redundant access specifier has the same accessibility as the
previous access specifier [readability-redundant-access-specifiers]
```suggestion
```
**be/src/olap/rowset/segment_v2/segment_iterator.h:88:** previously declared
here
```cpp
private:
^
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
