github-actions[bot] commented on code in PR #13035:
URL: https://github.com/apache/doris/pull/13035#discussion_r1056378576
##########
be/src/olap/rowset/segment_v2/segment_iterator.cpp:
##########
@@ -1241,6 +1425,53 @@ Status SegmentIterator::next_batch(vectorized::Block*
block) {
return Status::OK();
}
+void SegmentIterator::_output_index_result_column(uint16_t* sel_rowid_idx,
uint16_t select_size,
+ vectorized::Block* block) {
+ if (block->rows() == 0) {
+ return;
+ }
+
+ for (auto iter : _rowid_result_for_index) {
+ block->insert({vectorized::ColumnUInt8::create(),
+ std::make_shared<vectorized::DataTypeUInt8>(),
iter.first});
+ if (!iter.second.first) {
+ // predicate not in compound query
+ continue;
+ }
+ _build_index_result_column(sel_rowid_idx, select_size, block,
iter.first,
+ iter.second.second);
+ }
+}
+
+void SegmentIterator::_build_index_result_column(uint16_t* sel_rowid_idx,
uint16_t select_size,
Review Comment:
warning: pointer parameter 'sel_rowid_idx' can be pointer to const
[readability-non-const-parameter]
```suggestion
void SegmentIterator::_build_index_result_column(const uint16_t*
sel_rowid_idx, uint16_t select_size,
```
be/src/olap/rowset/segment_v2/segment_iterator.h:190:
```diff
- void _build_index_result_column(uint16_t* sel_rowid_idx, uint16_t
select_size,
+ void _build_index_result_column(const uint16_t* sel_rowid_idx,
uint16_t select_size,
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
