[GitHub] [doris] JackDrogon commented on a diff in pull request #15250: (improvement)[bucket] Add auto bucket implement

[GitBox]

JackDrogon commented on code in PR #15250:
URL: https://github.com/apache/doris/pull/15250#discussion_r1057086725


##########
fe/fe-core/src/main/java/org/apache/doris/analysis/DistributionDesc.java:
##########
@@ -52,27 +70,10 @@ public DistributionInfo toDistributionInfo(List<Column> 
columns) throws DdlExcep
         throw new NotImplementedException();
     }
 
-    public static DistributionDesc read(DataInput in) throws IOException {
-        DistributionInfoType type = 
DistributionInfoType.valueOf(Text.readString(in));
-        if (type == DistributionInfoType.HASH) {
-            DistributionDesc desc = new HashDistributionDesc();
-            desc.readFields(in);
-            return desc;
-        } else if (type == DistributionInfoType.RANDOM) {
-            DistributionDesc desc = new RandomDistributionDesc();
-            desc.readFields(in);
-            return desc;
-        } else {
-            throw new IOException("Unknown distribution type: " + type);
-        }
-    }
-
     @Override
     public void write(DataOutput out) throws IOException {
         Text.writeString(out, type.name());
-    }
-
-    public void readFields(DataInput in) throws IOException {
-        throw new NotImplementedException();
+        out.writeInt(numBucket);

Review Comment:
   I check all the code， FE not use DistributionDesc write/read. It use 
DistributionInfo write/read function, so I not add autoBucket in these 
functions, just add them in property and load it in OlapTable read with 
markAutoBucket



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org