JackDrogon commented on code in PR #15250: URL: https://github.com/apache/doris/pull/15250#discussion_r1056016421
########## fe/fe-core/src/main/java/org/apache/doris/common/util/AutoBucketUtils.java: ########## @@ -0,0 +1,97 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE file +// distributed with this work for additional information +// regarding copyright ownership. The ASF licenses this file +// to you under the Apache License, Version 2.0 (the +// "License"); you may not use this file except in compliance +// with the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, +// software distributed under the License is distributed on an +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +// KIND, either express or implied. See the License for the +// specific language governing permissions and limitations +// under the License. + +package org.apache.doris.common.util; + +import org.apache.doris.catalog.DiskInfo; +import org.apache.doris.catalog.DiskInfo.DiskState; +import org.apache.doris.catalog.Env; +import org.apache.doris.system.Backend; +import org.apache.doris.system.SystemInfoService; + +import com.google.common.collect.ImmutableMap; +import org.apache.logging.log4j.LogManager; +import org.apache.logging.log4j.Logger; + +public class AutoBucketUtils { + private static Logger logger = LogManager.getLogger(AutoBucketUtils.class); + + private static final long SIZE_100MB = 100 * 1024 * 1024L; + private static final long SIZE_1GB = 1 * 1024 * 1024 * 1024L; + + private static int getBENum() { + SystemInfoService infoService = Env.getCurrentSystemInfo(); + ImmutableMap<Long, Backend> backends = infoService.getBackendsInCluster(null); + + int activeBENum = 0; + for (Backend backend : backends.values()) { + if (backend.isAlive()) { + ++activeBENum; + } + } + return activeBENum; + } + + private static int getBucketsNumByBEDisks() { + SystemInfoService infoService = Env.getCurrentSystemInfo(); + ImmutableMap<Long, Backend> backends = infoService.getBackendsInCluster(null); + + int buckets = 0; + for (Backend backend : backends.values()) { + if (!backend.isLoadAvailable()) { + break; + } + + ImmutableMap<String, DiskInfo> disks = backend.getDisks(); + for (DiskInfo diskInfo : disks.values()) { + if (diskInfo.getState() == DiskState.ONLINE && diskInfo.hasPathHash()) { + buckets += (diskInfo.getAvailableCapacityB() - 1) / (50 * SIZE_1GB) + 1; + } + } + } + return buckets; + } + + private static int convertParitionSizeToBucketsNum(long partitionSize) { + partitionSize /= 5; // for compression 5:1 + + // <= 100MB, 1 bucket + // <= 1GB, 2 buckets + // > 1GB, round to (size / 1G) + if (partitionSize <= SIZE_100MB) { + return 1; + } else if (partitionSize <= SIZE_1GB) { + return 2; + } else { + return (int) ((partitionSize - 1) / SIZE_1GB + 1); + } + } + + public static int getBucketsNum(long partitionSize) { + int bucketsNumByPartitionSize = convertParitionSizeToBucketsNum(partitionSize); + int bucketsNumByBE = getBucketsNumByBEDisks(); + int bucketsNum = Math.min(128, Math.min(bucketsNumByPartitionSize, bucketsNumByBE)); + int beNum = getBENum(); + logger.info("AutoBucketsUtil: bucketsNumByPartitionSize {}, bucketsNumByBE {}, bucketsNum {}, beNum {}", Review Comment: I wrote by debug level before, but i check sys_log_level start from info, hmm. I think create table is not a common behaviour. so it's not a hotpot path -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
