yiguolei commented on code in PR #63622:
URL: https://github.com/apache/doris/pull/63622#discussion_r3302168081
##########
be/src/storage/segment/encoding_info.h:
##########
@@ -51,15 +51,19 @@ class DataPagePreDecoder {
class EncodingInfo {
public:
- // Get EncodingInfo for TypeInfo and EncodingTypePB
- static Status get(FieldType type, EncodingTypePB encoding_type,
- EncodingPreference encoding_preference, const
EncodingInfo** encoding);
+ // Look up the EncodingInfo for an already-resolved (type, encoding) pair.
+ // Read paths use this directly; write paths first resolve a default via
the
+ // get_*_default_encoding helpers below.
+ static Status get(FieldType type, EncodingTypePB encoding_type, const
EncodingInfo** encoding);
- // optimize_value_search: whether the encoding scheme should optimize for
ordered data
- // and support fast value seek operation
- static EncodingTypePB get_default_encoding(FieldType type,
- EncodingPreference
encoding_preference,
- bool optimize_value_seek);
+ // Default column encoding for the legacy (V1/V2 segment) write path.
+ static EncodingTypePB get_legacy_default_encoding(FieldType type);
Review Comment:
rename to get_v2_default_encoding
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
