yiguolei commented on code in PR #63622:
URL: https://github.com/apache/doris/pull/63622#discussion_r3302051025
##########
be/src/storage/segment/segment_writer.cpp:
##########
@@ -146,11 +147,13 @@ SegmentWriter::~SegmentWriter() {
}
void SegmentWriter::init_column_meta(ColumnMetaPB* meta, uint32_t column_id,
- const TabletColumn& column,
TabletSchemaSPtr tablet_schema) {
+ const TabletColumn& column, bool
use_v3_default_encoding) {
Review Comment:
我觉得还是直接传递tablet schema 更好一些，未来我们如果再给schema 加开关或者属性，不能一直扩参数列表
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
