github-actions[bot] commented on code in PR #63648:
URL: https://github.com/apache/doris/pull/63648#discussion_r3300932991
##########
fe/fe-core/src/main/java/org/apache/doris/datasource/hudi/source/HudiScanNode.java:
##########
@@ -170,6 +170,7 @@ protected void doInitialize() throws UserException {
initBackendPolicy();
initSchemaParams();
+ long startTime = System.currentTimeMillis();
Review Comment:
This table-metadata timer is still skipped for Hudi tables with no completed
instant. In `doInitialize()`, after loading the timeline, the
`!snapshotInstant.isPresent()` branch sets `prunedPartitions` and returns
before reaching `addExternalTableGetTableMetaTime(...)`. That path has already
done Hudi client/timeline metadata work (`getHudiClient()`,
`reloadActiveTimeline()`, `getCommitsAndCompactionTimeline()`), but the new
`External Table Get Table Meta Time` and aggregate external meta time remain
`N/A`/zero for an empty Hudi table. Please record this with a `finally` around
the initialized section or add the metric before that early return.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
