github-actions[bot] commented on code in PR #63648:
URL: https://github.com/apache/doris/pull/63648#discussion_r3300928694
##########
fe/fe-core/src/main/java/org/apache/doris/datasource/hudi/source/HudiScanNode.java:
##########
@@ -170,6 +170,7 @@ protected void doInitialize() throws UserException {
initBackendPolicy();
initSchemaParams();
+ long startTime = System.currentTimeMillis();
hudiClient = hmsTable.getHudiClient();
Review Comment:
This timer is not recorded on the successful empty-table path. `startTime`
is set here, but if the Hudi timeline has no completed instant, lines 211-215
set `prunedPartitions` and `partitionInit` and then `return` before the new
`addExternalTableGetTableMetaTime(...)` call below. As a result, an empty Hudi
table still does the metadata work (`getHudiClient`, `reloadActiveTimeline`,
remote table fields, timeline lookup) but `External Table Meta Time` remains
missing it. Please put the table-meta accounting in a `finally` or record it
before this early return.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
