zhannngchen commented on code in PR #15018:
URL: https://github.com/apache/doris/pull/15018#discussion_r1047075452
##########
be/src/olap/memtable.h:
##########
@@ -224,6 +224,8 @@ class MemTable {
DeleteBitmapPtr _delete_bitmap;
RowsetIdUnorderedSet _rowset_ids;
int64_t _cur_max_version;
+ // seg ids in one _do_flush for calc delete bitmap
+ std::vector<int64_t> _seg_ids;
Review Comment:
We don't need to record a vector, for MoW table, memtable is flushed one by
one (`should_serial = true` when `create_flush_token`), and `segment_id` is
monotonically increasing, so we just need to record the segment id before
flushing, such as `num_segs_before_flush`, and we just need to load segments
between `num_seg_before_flush` and `num_segments`
BTW. in this way, we don't need to change the interface definition of method
`add_block`, which looks a little wired in current solution.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
