liaoxin01 commented on code in PR #15018:
URL: https://github.com/apache/doris/pull/15018#discussion_r1045617277
##########
be/src/olap/rowset/rowset_writer.h:
##########
@@ -62,10 +62,12 @@ class RowsetWriter {
virtual Status flush_columns() { return
Status::Error<ErrorCode::NOT_IMPLEMENTED_ERROR>(); }
virtual Status final_flush() { return
Status::Error<ErrorCode::NOT_IMPLEMENTED_ERROR>(); }
- virtual Status flush_single_memtable(MemTable* memtable, int64_t*
flush_size) {
+ virtual Status flush_single_memtable(MemTable* memtable, int64_t*
flush_size,
+ std::vector<int64_t>*
seg_ids_for_delete_bitmap) {
Review Comment:
seg_ids_for_delete_bitmap -> seg_ids may be more generic.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
