morningman commented on code in PR #14470:
URL: https://github.com/apache/doris/pull/14470#discussion_r1046824895
##########
fe/fe-core/src/main/java/org/apache/doris/planner/external/IcebergScanProvider.java:
##########
@@ -59,13 +75,21 @@
public class IcebergScanProvider extends HiveScanProvider {
private static final int MIN_DELETE_FILE_SUPPORT_VERSION = 2;
+ public static final String V2_DELETE_TBL = "iceberg#delete#tbl";
+ public static final String V2_DELETE_DB = "iceberg#delete#db";
+ private static final DeleteFileTempTable scanDeleteTable =
+ new DeleteFileTempTable(TableIf.TableType.HMS_EXTERNAL_TABLE);
+ private BaseTableRef tableRef;
Review Comment:
Remove this `tableRef`
##########
fe/fe-core/src/main/java/org/apache/doris/planner/external/IcebergSplit.java:
##########
@@ -28,8 +31,11 @@ public IcebergSplit(Path file, long start, long length,
String[] hosts) {
super(file, start, length, hosts);
}
+ private Analyzer analyzer;
private String dataFilePath;
private Integer formatVersion;
+ private BaseTableRef baseTableRef;
+ private IcebergScanProvider.DeleteFileTempTable deleteFileTable;
Review Comment:
Remove `deleteFileTable`, you can get it from `BaseTableRef `
##########
fe/fe-core/src/main/java/org/apache/doris/planner/external/IcebergSplit.java:
##########
@@ -28,8 +31,11 @@ public IcebergSplit(Path file, long start, long length,
String[] hosts) {
super(file, start, length, hosts);
}
+ private Analyzer analyzer;
private String dataFilePath;
private Integer formatVersion;
+ private BaseTableRef baseTableRef;
Review Comment:
```suggestion
private BaseTableRef deleteTableRef;
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
