morningman commented on code in PR #14470:
URL: https://github.com/apache/doris/pull/14470#discussion_r1042362877
##########
fe/fe-core/src/main/java/org/apache/doris/planner/external/IcebergScanProvider.java:
##########
@@ -136,16 +177,33 @@ public List<InputSplit> getSplits(List<Expr> exprs)
throws UserException {
List<InputSplit> splits = new ArrayList<>();
int formatVersion = ((BaseTable)
table).operations().current().formatVersion();
+ DeleteFileTempTable deleteFileTable = null;
+ if (formatVersion >= MIN_DELETE_FILE_SUPPORT_VERSION) {
+ String dbName =
ClusterNamespace.getFullName(analyzer.getClusterName(), hmsTable.getDbName());
+ deleteFileTable = new DeleteFileTempTable(hmsTable.getCatalog(),
Review Comment:
You don't need to create `DeleteFileTempTable` for every split.
You can just create a final static member of this table somewhere, Because
it just save a schema of delete file.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
