yiguolei commented on code in PR #14712:
URL: https://github.com/apache/doris/pull/14712#discussion_r1040816859
##########
be/src/runtime/memory/thread_mem_tracker_mgr.cpp:
##########
@@ -49,15 +52,22 @@ void ThreadMemTrackerMgr::cancel_fragment() {
_check_limit = false; // Make sure it will only be canceled once
}
-void ThreadMemTrackerMgr::exceeded() {
+void ThreadMemTrackerMgr::exceeded(int64_t size) {
if (_cb_func != nullptr) {
_cb_func();
}
_limiter_tracker_raw->print_log_usage(_exceed_mem_limit_msg);
if (is_attach_query()) {
- // TODO wait gc
- cancel_fragment();
+ if (_is_process_exceed) {
Review Comment:
could sleep 100ms and then check if sys mem exceed limit until
thread_wait_gc_max_milliseconds. So that if there are memory available, we
could use it as soon as possible.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
