[GitHub] [doris] github-actions[bot] commented on a diff in pull request #14712: [enhancement](memory) Add Memory GC when the available memory of the BE process is lacking

Tue, 06 Dec 2022 09:05:34 -0800 


github-actions[bot] commented on code in PR #14712:
URL: https://github.com/apache/doris/pull/14712#discussion_r1041234616


##########
be/src/olap/lru_cache.h:
##########
@@ -370,6 +372,7 @@ class ShardedLRUCache : public Cache {
     virtual uint64_t new_id() override;
     virtual int64_t prune() override;
     virtual int64_t prune_if(CacheValuePredicate pred) override;
+    virtual int64_t mem_consumption() override;
 
 private:
     void update_cache_metrics() const;

Review Comment:
   warning: 'virtual' is redundant since the function is already declared 
'override' [modernize-use-override]
   
   be/src/olap/lru_cache.h:374:
   ```diff
   - _if(CacheValuePredicate pred) override;
   - ual int64_t mem_consumption() override;
   - al int64_t mem_consumption() override;
   + _if(CacheValuePredicate pred) override;
   + ual mem_consumption() override;
   + al int64_t mem_consumption() override;
   ```
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org

Reply via email to