HappenLee commented on code in PR #14633:
URL: https://github.com/apache/doris/pull/14633#discussion_r1033322903
##########
be/src/vec/columns/column_nullable.cpp:
##########
@@ -243,9 +244,10 @@ void
ColumnNullable::deserialize_vec(std::vector<StringRef>& keys, const size_t
void ColumnNullable::insert_range_from(const IColumn& src, size_t start,
size_t length) {
const ColumnNullable& nullable_col = assert_cast<const
ColumnNullable&>(src);
- get_null_map_column().insert_range_from(*nullable_col.null_map, start,
length);
+ _get_null_map_column().insert_range_from(*nullable_col.null_map, start,
length);
get_nested_column().insert_range_from(*nullable_col.nested_column, start,
length);
auto& src_null_map_data = nullable_col.get_null_map_data();
+ _has_null = has_null();
_has_null |= simd::contain_byte(src_null_map_data.data() + start, length,
1);
Review Comment:
many do muit compute ? rethink the logic
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
