[GitHub] [doris] HappenLee commented on a diff in pull request #14633: [improvement](vec) optimize the logic for _has_null in ColumnNullable

[GitBox]

HappenLee commented on code in PR #14633:
URL: https://github.com/apache/doris/pull/14633#discussion_r1033321950


##########
be/src/vec/columns/column_nullable.cpp:
##########
@@ -575,12 +579,15 @@ void ColumnNullable::sort_column(const ColumnSorter* 
sorter, EqualFlags& flags,
 }
 
 void ColumnNullable::_update_has_null() {
-    const UInt8* null_pos = get_null_map_data().data();
-    _has_null = simd::contain_byte(null_pos, get_null_map_data().size(), 1);
+    const UInt8* null_pos = _get_null_map_data().data();
+    _has_null = simd::contain_byte(null_pos, _get_null_map_data().size(), 1);
     _need_update_has_null = false;
 }
 
 bool ColumnNullable::has_null(size_t size) const {
+    if (!_has_null && !_need_update_has_null) {
+        return false;
+    }
     const UInt8* null_pos = get_null_map_data().data();

Review Comment:
   `_get_null_map_data()`
   
   should abstruct a function for the code line 582/591



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org