924060929 commented on code in PR #14380:
URL: https://github.com/apache/doris/pull/14380#discussion_r1026294286
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/trees/expressions/functions/scalar/Substring.java:
##########
@@ -66,8 +66,9 @@ public Substring(Expression arg0, Expression arg1, Expression
arg2) {
}
@Override
- protected FunctionSignature computeSignature(FunctionSignature signature) {
- Optional<Expression> length = getLength();
+ protected FunctionSignature computeSignature(FunctionSignature signature,
List<Expression> arguments) {
+ Optional<Expression> length = arguments.size() == 2
Review Comment:
my fault
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
