924060929 commented on code in PR #14380:
URL: https://github.com/apache/doris/pull/14380#discussion_r1026274825
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/glue/translator/PhysicalPlanTranslator.java:
##########
@@ -217,11 +217,7 @@ public PlanFragment visitPhysicalAggregate(
outputTupleDesc = localAggNode.getAggInfo().getOutputTupleDesc();
}
- if (aggregate.getAggPhase() == AggPhase.GLOBAL) {
- for (FunctionCallExpr execAggregateFunction :
execAggregateFunctions) {
- execAggregateFunction.setMergeForNereids(true);
- }
- }
Review Comment:
already move to ExpressionTranslator.visitAggregateFunction(), there has a
line:
```java
boolean isMergeFn = function.isGlobal() && function.isDisassembled();
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
