airborne12 commented on code in PR #14211:
URL: https://github.com/apache/doris/pull/14211#discussion_r1023421966
##########
be/src/olap/in_list_predicate.h:
##########
@@ -241,6 +242,29 @@ class InListPredicateBase : public ColumnPredicate {
return Status::OK();
}
+ Status evaluate(const Schema& schema, InvertedIndexIterator* iterator,
+ uint32_t num_rows, roaring::Roaring* result) const
override {
+ if (iterator == nullptr) {
+ return Status::OK();
+ }
+ auto column_desc = schema.column(_column_id);
+ std::string column_name = column_desc->name();
+ roaring::Roaring indices;
+ for (auto value : *_values) {
Review Comment:
don't need to 'for each value then merge result', read_from_inverted_index
can process multiple values query. In other words, we can push down IN_LIST
query to inverted index query layer.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
