Gabriel39 commented on code in PR #59488:
URL: https://github.com/apache/doris/pull/59488#discussion_r2667293565
##########
be/src/vec/columns/column_decimal.h:
##########
@@ -142,8 +142,7 @@ class ColumnDecimal final : public COWHelper<IColumn,
ColumnDecimal<T>> {
void insert_data(const char* pos, size_t /*length*/) override;
void insert_default() override { data.push_back(value_type()); }
void insert(const Field& x) override {
- data.push_back(
- doris::vectorized::get<typename
PrimitiveTypeTraits<T>::NearestFieldType>(x));
+ data.push_back(x.template get<typename
PrimitiveTypeTraits<T>::ColumnItemType>());
Review Comment:
decimalv2不行，这个等下个pr改
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
