Gabriel39 commented on code in PR #59488:
URL: https://github.com/apache/doris/pull/59488#discussion_r2667176896
##########
be/src/olap/in_list_predicate.h:
##########
@@ -254,19 +255,8 @@ class InListPredicateBase final : public ColumnPredicate {
}
bool camp_field(const vectorized::Field& min_field, const
vectorized::Field& max_field) const {
- T min_value;
- T max_value;
- if constexpr (is_int_or_bool(Type) || is_float_or_double(Type)) {
- min_value =
- (typename PrimitiveTypeTraits<Type>::CppType)min_field
- .template get<typename
PrimitiveTypeTraits<Type>::NearestFieldType>();
- max_value =
- (typename PrimitiveTypeTraits<Type>::CppType)max_field
- .template get<typename
PrimitiveTypeTraits<Type>::NearestFieldType>();
- } else {
- min_value = min_field.template get<typename
PrimitiveTypeTraits<Type>::CppType>();
- max_value = max_field.template get<typename
PrimitiveTypeTraits<Type>::CppType>();
- }
+ T min_value = min_field.template get<T>();
Review Comment:
ref
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
