gavinchou commented on code in PR #56065:
URL: https://github.com/apache/doris/pull/56065#discussion_r2375123348
##########
be/src/util/s3_util.cpp:
##########
@@ -269,7 +270,7 @@ std::shared_ptr<Aws::Auth::AWSCredentialsProvider>
S3ClientFactory::get_aws_cred
if (s3_conf.cred_provider_type == CredProviderType::InstanceProfile) {
if (s3_conf.role_arn.empty()) {
- return
std::make_shared<Aws::Auth::InstanceProfileCredentialsProvider>();
+ return
std::make_shared<Aws::Auth::DefaultAWSCredentialsProviderChain>();
Review Comment:
we should not touch the existing impl which is going to be removed in the
future?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
