SWJTU-ZhangLei commented on code in PR #56065:
URL: https://github.com/apache/doris/pull/56065#discussion_r2378770721
##########
fe/fe-core/src/main/java/org/apache/doris/datasource/property/storage/S3Properties.java:
##########
@@ -280,8 +282,7 @@ private void convertGlueToS3EndpointIfNeeded() {
}
}
- @Override
- public AwsCredentialsProvider getAwsCredentialsProvider() {
Review Comment:
> it is better we do the provider inside this function instead removing this
function and add other new names xxv1 xxv2. e.g.
>
> ```
> public AwsCredentialsProvider getAwsCredentialsProvider() {
> if (config.v1) return providerChainV1()
> else (config.v2) return providerChainV2()
> }
> ```
```
@Override
public AwsCredentialsProvider getAwsCredentialsProvider() {
if (Config.enable_custom_aws_credentials_chain) {
return getAwsCredentialsProviderV2();
}
return getAwsCredentialsProviderV1();
}
```
the original func `getAwsCredentialsProvider` still exist
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
