dataroaring commented on PR #55950:
URL: https://github.com/apache/doris/pull/55950#issuecomment-3284081407
**Question: Privilege Type Consistency**
**File**: `be/src/http/action/check_encryption_action.cpp`
**Issue**: The new encryption check endpoint uses `TPrivilegeType::ALL`,
which differs from other admin endpoints that typically use
`TPrivilegeType::ADMIN`.
**Code**:
```cpp
Status CheckEncryptionAction::check_tablet_encryption_request(HttpRequest*
req, TCheckTabletEncryptionReq& request) {
// Uses TPrivilegeType::ALL
```
**Questions**:
1. Is `TPrivilegeType::ALL` the intended privilege level for encryption
checks?
2. Should this be `TPrivilegeType::ADMIN` to match other administrative
endpoints?
3. What's the security reasoning for requiring ALL privileges vs ADMIN
privileges?
**Security Consideration**:
- `ALL` privilege is typically broader than `ADMIN`
- Encryption status might be sensitive information that should be restricted
**Recommendation**: Please clarify the intended privilege level and ensure
it aligns with the security model for TDE-related operations.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
