dataroaring commented on PR #55950:
URL: https://github.com/apache/doris/pull/55950#issuecomment-3284079993
**Remove Commented Code Block**
**File**:
`fe/fe-core/src/main/java/org/apache/doris/planner/external/paimon/PaimonScanNode.java`
and `PropertyAnalyzer.java`
**Issue**: Large blocks of commented-out code are present, particularly
around lines 1903-1912 in PropertyAnalyzer.java.
**Problems**:
- Makes code harder to read and maintain
- Suggests incomplete refactoring
- Version control already maintains code history
- Unclear whether code should be restored or permanently removed
**Recommendation**:
- **Remove** the commented code blocks entirely
- If the code needs to be preserved for future reference, document the
reasoning in a TODO comment
- Use git history to reference old implementations if needed
**Example**:
```java
// Remove these commented blocks:
// if (properties.containsKey(PropertyAnalyzer.PROPERTIES_COLOCATE_WITH)) {
// ... (multiple lines of commented code)
// If truly needed for future work, replace with:
// TODO: Implement colocate_with property validation for TDE scenarios (see
commit ABC123)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
