HappenLee commented on code in PR #12146:
URL: https://github.com/apache/doris/pull/12146#discussion_r959244569
##########
be/src/exec/text_converter.hpp:
##########
@@ -169,19 +169,17 @@ inline bool TextConverter::write_slot(const
SlotDescriptor* slot_desc, Tuple* tu
inline void TextConverter::write_string_column(const SlotDescriptor* slot_desc,
vectorized::MutableColumnPtr*
column_ptr,
const char* data, size_t len) {
- vectorized::IColumn* col_ptr = column_ptr->get();
- // \N means it's NULL
- if (LIKELY(slot_desc->is_nullable())) {
- auto* nullable_column =
reinterpret_cast<vectorized::ColumnNullable*>(column_ptr->get());
- if ((len == 2 && data[0] == '\\' && data[1] == 'N') || len ==
SQL_NULL_DATA) {
- nullable_column->insert_data(nullptr, 0);
- return;
- } else {
- nullable_column->get_null_map_data().push_back(0);
- col_ptr = &nullable_column->get_nested_column();
- }
+ DCHECK(column_ptr->get()->is_nullable());
+ auto* nullable_column =
reinterpret_cast<vectorized::ColumnNullable*>(column_ptr->get());
+ if (len == 2 && data[0] == '\\' && data[1] == 'N') {
Review Comment:
you code will cause unless virtual function call
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
