HappenLee commented on code in PR #12146:
URL: https://github.com/apache/doris/pull/12146#discussion_r958004376
##########
be/src/vec/functions/function_helpers.cpp:
##########
@@ -26,6 +26,42 @@
namespace doris::vectorized {
+Block create_block_with_nested_columns_only_args(const Block& block, const
ColumnNumbers& args) {
+ std::unordered_set<size_t> args_set(args.begin(), args.end());
+ Block res;
+ size_t columns = block.columns();
+
+ for (size_t i = 0; i < columns; ++i) {
Review Comment:
ok
##########
be/src/vec/exec/vbroker_scanner.cpp:
##########
@@ -98,19 +99,8 @@ Status VBrokerScanner::_fill_dest_columns(const Slice& line,
int dest_index = idx++;
auto src_slot_desc = _src_slot_descs[i];
- if (!src_slot_desc->is_materialized()) {
- continue;
- }
const Slice& value = _split_values[i];
- if (is_null(value)) {
Review Comment:
do not need， the null value will process in `writhe_string_column`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
