wangshuo128 commented on code in PR #12147:
URL: https://github.com/apache/doris/pull/12147#discussion_r957977717
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/memo/Memo.java:
##########
@@ -66,37 +67,18 @@ public Map<GroupExpression, GroupExpression>
getGroupExpressions() {
* Add plan to Memo.
* TODO: add ut later
*
- * @param node {@link Plan} or {@link Expression} to be added
+ * @param plan {@link Plan} or {@link Expression} to be added
* @param target target group to add node. null to generate new Group
* @param rewrite whether to rewrite the node to the target group
* @return a pair, in which the first element is true if a newly generated
groupExpression added into memo,
Review Comment:
The return value is not a pair anymore, comments should be updated
accordingly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
