jackwener commented on code in PR #12147:
URL: https://github.com/apache/doris/pull/12147#discussion_r956998102
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/properties/LogicalProperties.java:
##########
@@ -50,4 +50,21 @@ public List<Slot> getOutput() {
public LogicalProperties withOutput(List<Slot> output) {
return new LogicalProperties(Suppliers.ofInstance(output));
}
+
+ @Override
+ public boolean equals(Object o) {
+ if (this == o) {
+ return true;
+ }
+ if (o == null || getClass() != o.getClass()) {
+ return false;
+ }
+ LogicalProperties that = (LogicalProperties) o;
+ return Objects.equals(outputSupplier.get(), that.outputSupplier.get());
+ }
+
+ @Override
+ public int hashCode() {
+ return Objects.hash(outputSupplier.get());
+ }
Review Comment:
It's useless for `Helper class`
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/properties/UnboundLogicalProperties.java:
##########
@@ -37,4 +37,14 @@ public UnboundLogicalProperties() {
public List<Slot> getOutput() {
throw new UnboundException("getOutput");
}
+
Review Comment:
ditto
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
