gavinchou commented on code in PR #53468:
URL: https://github.com/apache/doris/pull/53468#discussion_r2219111448
##########
cloud/src/recycler/recycler.cpp:
##########
@@ -2505,6 +2518,107 @@ int InstanceRecycler::recycle_rowsets() {
return ret;
}
+int InstanceRecycler::recycle_rowset_meta_and_data(std::string_view key,
+ const RowsetMetaCloudPB&
rowset_meta) {
+ constexpr int MAX_RETRY = 10;
+ int64_t tablet_id = rowset_meta.tablet_id();
+ const std::string& rowset_id = rowset_meta.rowset_id_v2();
+ for (int i = 0; i < MAX_RETRY; ++i) {
+ std::unique_ptr<Transaction> txn;
+ TxnErrorCode err = txn_kv_->create_txn(&txn);
+ if (err != TxnErrorCode::TXN_OK) {
+ LOG_WARNING("failed to create txn").tag("err", err);
+ return -1;
+ }
+
+ std::string rowset_ref_count_key =
+ versioned::data_rowset_ref_count_key({instance_id_, tablet_id,
rowset_id});
Review Comment:
do we need to handle mvcc kvs if the instance is not mvcc enabled?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
