gavinchou commented on code in PR #53468: URL: https://github.com/apache/doris/pull/53468#discussion_r2222875848
########## cloud/src/recycler/recycler.cpp: ########## @@ -2172,47 +2178,64 @@ int InstanceRecycler::recycle_tablet(int64_t tablet_id, RecyclerMetricsContext& max_rowset_creation_time = std::max(max_rowset_creation_time, rs_meta.creation_time()); min_rowset_expiration_time = std::min(min_rowset_expiration_time, rs_meta.txn_expiration()); max_rowset_expiration_time = std::max(max_rowset_expiration_time, rs_meta.txn_expiration()); - resource_ids.emplace(rs_meta.resource_id()); - } - - LOG_INFO("recycle tablet start to delete object") - .tag("instance id", instance_id_) - .tag("tablet id", tablet_id) - .tag("recycle tablet resource ids are", - std::accumulate(resource_ids.begin(), resource_ids.begin(), std::string(), - [](std::string rs_id, const auto& it) { - return rs_id.empty() ? it : rs_id + ", " + it; - })); - SyncExecutor<int> concurrent_delete_executor( - _thread_pool_group.s3_producer_pool, - fmt::format("delete tablet {} s3 rowset", tablet_id), - [](const int& ret) { return ret != 0; }); + concurrent_delete_executor.add([tablet_id, rs_meta_pb = rs_meta, this]() { Review Comment: 考虑在这里通过判断instance是否开启mvcc 来做分叉处理, 没开的走旧的逻辑, 开了走新的逻辑, 影响可控, 效率可能也好一些. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org