morrySnow commented on code in PR #11812: URL: https://github.com/apache/doris/pull/11812#discussion_r953357704
########## fe/fe-core/src/main/java/org/apache/doris/nereids/rules/analysis/BindSlotReference.java: ########## @@ -92,9 +92,10 @@ public List<Rule> buildRules() { RuleType.BINDING_JOIN_SLOT.build( logicalJoin().thenApply(ctx -> { LogicalJoin<GroupPlan, GroupPlan> join = ctx.root; - Optional<Expression> cond = join.getCondition() + Optional<Expression> cond = join.getOtherJoinCondition() Review Comment: when resolve, join only has other join condition, but bind hash equal condition will bring more robustness -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org