morrySnow commented on code in PR #11812:
URL: https://github.com/apache/doris/pull/11812#discussion_r953357154
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/trees/plans/logical/LogicalJoin.java:
##########
@@ -177,18 +213,28 @@ public JoinReorderContext getJoinReorderContext() {
@Override
public LogicalBinary<Plan, Plan> withChildren(List<Plan> children) {
Preconditions.checkArgument(children.size() == 2);
- return new LogicalJoin<>(joinType, condition, children.get(0),
children.get(1), joinReorderContext);
+ return new LogicalJoin<>(joinType, hashJoinConjuncts,
otherJoinCondition, children.get(0), children.get(1));
}
@Override
public Plan withGroupExpression(Optional<GroupExpression> groupExpression)
{
- return new LogicalJoin<>(joinType, condition, groupExpression,
- Optional.of(logicalProperties), left(), right(),
joinReorderContext);
+ return new LogicalJoin<>(joinType, hashJoinConjuncts,
otherJoinCondition, groupExpression,
+ Optional.of(logicalProperties), left(), right());
}
@Override
public Plan withLogicalProperties(Optional<LogicalProperties>
logicalProperties) {
- return new LogicalJoin<>(joinType, condition, Optional.empty(),
logicalProperties, left(), right(),
- joinReorderContext);
+ return new LogicalJoin<>(joinType, hashJoinConjuncts,
otherJoinCondition,
+ Optional.empty(), logicalProperties, left(), right());
+ }
+
+ @Override
+ public LEFT_CHILD_TYPE left() {
+ return (LEFT_CHILD_TYPE) child(0);
+ }
+
+ @Override
+ public RIGHT_CHILD_TYPE right() {
+ return (RIGHT_CHILD_TYPE) child(1);
Review Comment:
yes, otherwise we need to cast child to plan explicitly in many place.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
