yujun777 commented on code in PR #49982:
URL: https://github.com/apache/doris/pull/49982#discussion_r2209067119
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/trees/TreeNode.java:
##########
@@ -150,22 +150,20 @@ default NODE_TYPE
rewriteDownShortCircuit(Function<NODE_TYPE, NODE_TYPE> rewrite
/**
* similar to rewriteDownShortCircuit, except that only subtrees, whose
root satisfies
- * border predicate are rewritten.
+ * border predicate are rewritten, and if a node not match predicate, then
its descendant will not rewrite.
*/
default NODE_TYPE rewriteDownShortCircuitDown(Function<NODE_TYPE,
NODE_TYPE> rewriteFunction,
- Predicate border, boolean aboveBorder) {
+ Predicate predicate) {
Review Comment:
this function no usage before, and the second arg is not friendly for use,
so this pr reuse this function and delete the second arg.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
