yujun777 commented on code in PR #49982:
URL: https://github.com/apache/doris/pull/49982#discussion_r2209064420
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/rules/expression/ExpressionNormalizationAndOptimization.java:
##########
@@ -21,17 +21,23 @@
import com.google.common.collect.ImmutableList;
+import java.util.List;
+
/** ExpressionNormalizationAndOptimization */
public class ExpressionNormalizationAndOptimization extends ExpressionRewrite {
/** ExpressionNormalizationAndOptimization */
- public ExpressionNormalizationAndOptimization() {
- super(new ExpressionRuleExecutor(
-
ImmutableList.<ExpressionRewriteRule<ExpressionRewriteContext>>builder()
-
.addAll(ExpressionNormalization.NORMALIZE_REWRITE_RULES)
- .addAll(ExpressionOptimization.OPTIMIZE_REWRITE_RULES)
- .addAll(ExpressionOptimization.ADD_RANGE)
- .build()
- ));
+ public ExpressionNormalizationAndOptimization(boolean addRange) {
+ super(new ExpressionRuleExecutor(buildRewriteRule(addRange)));
+ }
+
+ private static List<ExpressionRewriteRule<ExpressionRewriteContext>>
buildRewriteRule(boolean addRange) {
+ ImmutableList.Builder<ExpressionRewriteRule<ExpressionRewriteContext>>
builder = ImmutableList.builder();
+ builder.addAll(ExpressionNormalization.NORMALIZE_REWRITE_RULES)
+ .addAll(ExpressionOptimization.OPTIMIZE_REWRITE_RULES);
+ if (addRange) {
Review Comment:
add annotation
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
