dataroaring commented on code in PR #11835:
URL: https://github.com/apache/doris/pull/11835#discussion_r947390476
##########
be/src/runtime/descriptors.cpp:
##########
@@ -399,7 +399,10 @@ int RowDescriptor::get_row_size() const {
}
int RowDescriptor::get_tuple_idx(TupleId id) const {
- CHECK_LT(id, _tuple_idx_map.size()) << "RowDescriptor: " << debug_string();
+ DCHECK_LT(id, _tuple_idx_map.size()) << "RowDescriptor: " <<
debug_string();
Review Comment:
DCHECK also would be core dump in DEBUG MODE, we should comment DCHECK to
make sqlsmith run further.
##########
be/src/runtime/descriptors.h:
##########
@@ -382,6 +382,13 @@ class DescriptorTbl {
DescriptorTbl() = default;
};
+#define RETURN_IF_INVALID_IDX(tuple_id, tuple_idx)
\
Review Comment:
RETURN_IF_INVALID_TUPLE_IDX
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
