ByteYue opened a new pull request, #11835: URL: https://github.com/apache/doris/pull/11835
# Proposed changes Issue Number: close #xxx ## Problem summary The original get_tuple_idx function would check whether tuple_id is less than tuple map' size using CHECK macro. It might shut down the whole process once the check failed like the image below.  Meanwhile, there exists other occasions where the caller of get_tuple_idx never checks if it returns a valid tuple_idx or not. This pr aims to enhance the robust during runtime by : 1. use DCHECK instead of CHECK to prevent surprisingly shutdown 2. add check logic when calling get_tuple_idx function ## Checklist(Required) 1. Does it affect the original behavior: - [ ] No 3. Has unit tests been added: - [ ] No 4. Has document been added or modified: - [ ] No 5. Does it need to update dependencies: - [ ] No 6. Are there any changes that cannot be rolled back: - [ ] No ## Further comments If this is a relatively large or complex change, kick off the discussion at [d...@doris.apache.org](mailto:d...@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
