morrySnow commented on code in PR #51333:
URL: https://github.com/apache/doris/pull/51333#discussion_r2111640557
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/rules/implementation/AggregateStrategies.java:
##########
@@ -322,7 +321,8 @@ public List<Rule> buildRules() {
),
RuleType.TWO_PHASE_AGGREGATE_SINGLE_DISTINCT_TO_MULTI.build(
basePattern
- .when(agg -> agg.getDistinctArguments().size() == 1 &&
couldConvertToMulti(agg))
+ .when(agg -> agg.getDistinctArguments().size() == 1
Review Comment:
this strategy maybe not good for ckbench
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/rules/implementation/AggregateStrategies.java:
##########
@@ -2086,4 +2086,18 @@ private boolean couldConvertToMulti(LogicalAggregate<?
extends Plan> aggregate)
}
return true;
}
+
+ private boolean shouldUseMultiDistinct(LogicalAggregate<? extends Plan>
aggregate) {
Review Comment:
why not update the code in Aggregate#mustUseMultiDistinctAgg ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
