mrhhsg commented on code in PR #11175:
URL: https://github.com/apache/doris/pull/11175#discussion_r929957897
##########
be/src/vec/exec/vaggregation_node.cpp:
##########
@@ -1155,10 +1226,13 @@ Status
AggregationNode::_merge_with_serialized_key(Block* block) {
auto emplace_result = [&]() {
if constexpr (IsPhmapTraits<HashTableType>::value) {
if (LIKELY(i + HASH_MAP_PREFETCH_DIST < rows)) {
- agg_method.data.prefetch_by_hash(
- hash_values[i +
HASH_MAP_PREFETCH_DIST]);
+ if constexpr
(IsParallelPhmapTraits<HashTableType>::value) {
Review Comment:
`IsPreSerializedKeysHashMethodTraits` is about `aggregate state`
I will combine `IsParallelPhmapTraits` and `IsPhmapTraits` in one traits.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
