Gabriel39 commented on code in PR #11175:
URL: https://github.com/apache/doris/pull/11175#discussion_r929492639
##########
be/src/vec/exec/vaggregation_node.cpp:
##########
@@ -1155,10 +1226,13 @@ Status
AggregationNode::_merge_with_serialized_key(Block* block) {
auto emplace_result = [&]() {
if constexpr (IsPhmapTraits<HashTableType>::value) {
if (LIKELY(i + HASH_MAP_PREFETCH_DIST < rows)) {
- agg_method.data.prefetch_by_hash(
- hash_values[i +
HASH_MAP_PREFETCH_DIST]);
+ if constexpr
(IsParallelPhmapTraits<HashTableType>::value) {
Review Comment:
FYI, maybe we can wrap `IsParallelPhmapTraits` and
`IsPreSerializedKeysHashMethodTraits` into one single Traits? Using
`IsPreSerializedKeysHashMethodTraits` above but `IsParallelPhmapTraits` here is
a bit confused
##########
be/src/vec/exec/vaggregation_node.h:
##########
@@ -356,46 +356,75 @@ struct AggregationMethodSingleNullableColumn : public
SingleColumnMethod {
using AggregatedDataWithUInt8Key =
FixedImplicitZeroHashMapWithCalculatedSize<UInt8, AggregateDataPtr>;
using AggregatedDataWithUInt16Key = FixedImplicitZeroHashMap<UInt16,
AggregateDataPtr>;
-using AggregatedDataWithUInt32Key = HashMap<UInt32, AggregateDataPtr,
HashCRC32<UInt32>>;
-using AggregatedDataWithUInt64Key = HashMap<UInt64, AggregateDataPtr,
HashCRC32<UInt64>>;
-using AggregatedDataWithUInt128Key = HashMap<UInt128, AggregateDataPtr,
HashCRC32<UInt128>>;
-using AggregatedDataWithUInt256Key = HashMap<UInt256, AggregateDataPtr,
HashCRC32<UInt256>>;
+using AggregatedDataWithUInt32Key = PHHashMap<UInt32, AggregateDataPtr,
HashCRC32<UInt32>>;
+using AggregatedDataWithUInt64Key = PHHashMap<UInt64, AggregateDataPtr,
HashCRC32<UInt64>>;
+using AggregatedDataWithUInt128Key = PHHashMap<UInt128, AggregateDataPtr,
HashCRC32<UInt128>>;
+using AggregatedDataWithUInt256Key = PHHashMap<UInt256, AggregateDataPtr,
HashCRC32<UInt256>>;
+using AggregatedDataWithUInt32KeyPhase2 =
+ PHHashMap<UInt32, AggregateDataPtr, HashMixWrapper<UInt32>>;
+using AggregatedDataWithUInt64KeyPhase2 =
+ PHHashMap<UInt64, AggregateDataPtr, HashMixWrapper<UInt64>>;
Review Comment:
What's different between `HashMixWrapper` and a pure `HashCRC32`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
