yiguolei commented on code in PR #50563:
URL: https://github.com/apache/doris/pull/50563#discussion_r2072788533
##########
fe/fe-core/src/main/java/org/apache/doris/analysis/AlterRoutineLoadStmt.java:
##########
@@ -257,19 +257,18 @@ private void checkJobProperties() throws UserException {
ConnectContext tmpCtx = new ConnectContext();
tmpCtx.setCurrentUserIdentity(ConnectContext.get().getCurrentUserIdentity());
tmpCtx.getSessionVariable().setWorkloadGroup(workloadGroup);
- long wgId;
try {
// NOTE(wb): why get 0th wg here;
// currently a routineload can only be executed in one
workload group;
// but the workload group thrift sent from FE to BE is a
list, this is for scalability.
- wgId = Env.getCurrentEnv().getWorkloadGroupMgr()
+ Env.getCurrentEnv().getWorkloadGroupMgr()
Review Comment:
不要依赖异常来报错，异常的错误信息是我们系统内的，用户看不懂，比如，这里如果用户指定的workload group
不存在，我们的报错信息可能就是index of bound exception，这个不是用户的信息
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
