xzj7019 commented on code in PR #49096:
URL: https://github.com/apache/doris/pull/49096#discussion_r2055588075
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/trees/expressions/functions/agg/Count.java:
##########
@@ -46,22 +46,29 @@ public class Count extends NotNullableAggregateFunction
);
private final boolean isStar;
+ private final boolean isSkew;
Review Comment:
skew mark in aggr distinct may not be a unique solution, since skew is not
used to desc distinct/group by, try to consider a alternative way by adding
hint at the end of group by, like 'group by [addSaltXXX(b)]' etc, with the
precondition that the agg skew happens for the whole list of group by key, and
it is also friendly to avoid adding the flag for other kinds of aggr function.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
